Fix #3548 add coordinate editor for GFI panel#3557
Merged
tdipisa merged 1 commit intogeosolutions-it:masterfrom Feb 25, 2019
Merged
Fix #3548 add coordinate editor for GFI panel#3557tdipisa merged 1 commit intogeosolutions-it:masterfrom
tdipisa merged 1 commit intogeosolutions-it:masterfrom
Conversation
9c6fc0a to
e804a0c
Compare
Contributor
mbarto
suggested changes
Feb 22, 2019
Contributor
mbarto
left a comment
There was a problem hiding this comment.
You always use comma as a decimal separator in coordinates editor. You should use the right separator for the current locale (comma is used mainly in Italy)
Contributor
Author
@mbarto I see the dots |
Contributor
Contributor
|
@MV88 if it depends on PC locale, then it's good, my only concern was if commas where used always |
mbarto
approved these changes
Feb 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
This pr add the coordinate editor in the header of GFI panel.
the flag used to show the button that trigger visibility of coord editor in the toolbar is true by default and is called "enabledCoordEditorButton"
by default the flag used to show the coordinate editor is false by default and is called "showCoordinateEditor"
Issues
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
What is the current behavior? (You can also link to an open issue here)
you cannot perform a GetFeatureInfo for exact coordinates
What is the new behavior?
you can use a coordinate editor to search custom point
Does this PR introduce a breaking change? (check one with "x", remove the other)
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
If you want to avoid to hidethe button in the toolbar (true by default)
or if you do not specify the previous config and you want to show the coordinate editor (by default is false), in the initialState add