Skip to content

Fixes #3554: external init of StandardApp#3555

Merged
mbarto merged 1 commit intogeosolutions-it:masterfrom
mbarto:app_on_init
Mar 6, 2019
Merged

Fixes #3554: external init of StandardApp#3555
mbarto merged 1 commit intogeosolutions-it:masterfrom
mbarto:app_on_init

Conversation

@mbarto
Copy link
Copy Markdown
Contributor

@mbarto mbarto commented Feb 20, 2019

Description

We want to be able to delegate app initialization so that custom applications can drive the initialization phase (e.g. force a login before application startup).

Issues

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe: new configuration option

What is the current behavior? (You can also link to an open issue here)
We cannot delegate app initialization so that custom applications can drive the initialization phase (e.g. force a login before application startup).

What is the new behavior?
We can delegate app initialization so that custom applications can drive the initialization phase (e.g. force a login before application startup).

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@mbarto mbarto added this to the 2019.01.01 milestone Feb 20, 2019
@ghost ghost assigned mbarto Feb 20, 2019
Copy link
Copy Markdown
Member

@offtherailz offtherailz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed we have to find a way to remove printing stuff from StandardApp. Should we open an issue for that?

@tdipisa tdipisa requested a review from offtherailz February 22, 2019 09:55
@mbarto mbarto merged commit a2ea25f into geosolutions-it:master Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow external initialization of StandardApp

4 participants