Skip to content

Fix #3417. Use correct click event object. #3426

Merged
offtherailz merged 1 commit intogeosolutions-it:c127_geonode_integrationfrom
offtherailz:fix_#3417
Dec 20, 2018
Merged

Fix #3417. Use correct click event object. #3426
offtherailz merged 1 commit intogeosolutions-it:c127_geonode_integrationfrom
offtherailz:fix_#3417

Conversation

@offtherailz
Copy link
Copy Markdown
Member

Description

This PR fixes click event management for Firefox. also externalize click handlers enhancer and add unit tests for it

Issues

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix

What is the current behavior? (You can also link to an open issue here)
Click and drag events do not work in Firefox. See #3417

What is the new behavior?
Click handlers are managed correctly also in firefox

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • No

@ghost ghost assigned offtherailz Dec 20, 2018
@offtherailz offtherailz merged commit 8ea0534 into geosolutions-it:c127_geonode_integration Dec 20, 2018
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.03%) to 80.649% when pulling 6fca958 on offtherailz:fix_#3417 into fa734f6 on geosolutions-it:c127_geonode_integration.

@offtherailz offtherailz added this to the 2019.01.00 milestone Jan 14, 2019
@offtherailz offtherailz deleted the fix_#3417 branch May 26, 2020 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants