Skip to content

Fix #3395. Follow cursor on click/forward/backward. Increased unit tests#3401

Merged
offtherailz merged 1 commit intogeosolutions-it:c127_geonode_integrationfrom
offtherailz:fix_3395
Dec 10, 2018
Merged

Fix #3395. Follow cursor on click/forward/backward. Increased unit tests#3401
offtherailz merged 1 commit intogeosolutions-it:c127_geonode_integrationfrom
offtherailz:fix_3395

Conversation

@offtherailz
Copy link
Copy Markdown
Member

Description

This pull request makes the timeline:

  • Center the timeline to the current time if snapped and the current time went out of view range
  • Positionate the time view range with the current time on the left (start time) in case of forward/backward animation ( at is goes during the animation).

Note: the 2nd point places the point at the start following the animation strategy, instead the 1st point simply center the point.

Issues

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Feature

What is the current behavior? (You can also link to an open issue here)

  • When the user click, the cursor may disappear from the viewport without any feedback, in case it snaps out of the current view range
  • If the user click on forward/backward moving the current time out of the current view range, the cursor disappears out (if you're not animating)

What is the new behavior?
The timeline centers to the current time, if snapped out of the view range

  • When the user click on the forward/backward buttons, the timeline moves to include the currentTime
  • If the user click on forward/backward the timeline always follow the cursor if it goes out of the view range

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • No

Other information:

This PR contains also some unit tests to cover timeline epics and playback settings and so increase test coverage.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.05%) to 80.694% when pulling f90018c on offtherailz:fix_3395 into 0bbb41e on geosolutions-it:c127_geonode_integration.

@offtherailz offtherailz merged commit 8eb5c93 into geosolutions-it:c127_geonode_integration Dec 10, 2018
@offtherailz offtherailz added this to the 2019.01.00 milestone Jan 14, 2019
@offtherailz offtherailz deleted the fix_3395 branch May 26, 2020 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants