#3287 Timeline zoom to current time#3369
Merged
offtherailz merged 12 commits intogeosolutions-it:c127_geonode_integrationfrom Dec 3, 2018
Merged
#3287 Timeline zoom to current time#3369offtherailz merged 12 commits intogeosolutions-it:c127_geonode_integrationfrom
offtherailz merged 12 commits intogeosolutions-it:c127_geonode_integrationfrom
Conversation
offtherailz
requested changes
Nov 29, 2018
Member
offtherailz
left a comment
There was a problem hiding this comment.
Still have to try it. but, apart from required changes, it looks good.
The parts of "REMOVE_LAYER" are fixes to previous version or they are a commit error?
| static propTypes = { | ||
| date: PropTypes.string, | ||
| onUpdate: PropTypes.func, | ||
| onZoomTo: PropTypes.func, |
Member
There was a problem hiding this comment.
Please name this onIconClick
| )) | ||
| )), | ||
|
|
||
| playbackStopWhenDeleteLayer: (action$, { getState = () => {} }= {}) => |
Member
There was a problem hiding this comment.
is this a part of the another issue?
| */ | ||
| setupTimelineExistingSettings: (action$, { getState = () => { } } = {}) => action$.ofType(UPDATE_LAYER_DIMENSION_DATA) | ||
| .exhaustMap(() => isAutoSelectEnabled(getState()) && !selectedLayerName(getState()) && get(layersWithTimeDataSelector(getState()), "[0].id") | ||
| setupTimelineExistingSettings: (action$, { getState = () => { } } = {}) => action$.ofType(REMOVE_NODE, UPDATE_LAYER_DIMENSION_DATA) |
Member
There was a problem hiding this comment.
again part of another issue?
Contributor
Author
|
These are results from merging an old branch (merged in #3359). |
offtherailz
approved these changes
Nov 30, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
utilizing the ''currentTime, ''range Start'', and ''Range end'' glyphes in the inlineDateTimeComponent.jsx to zoom/move to the current time or offset range.
Issues
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
What is the current behavior? (You can also link to an open issue here)
see #3287
What is the new behavior?
Does this PR introduce a breaking change? (check one with "x", remove the other)
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
waiting for @offtherailz approval I didn't update the localization files, if / once it is approved I'll push a commit with the translations.