Fix #3282. Implemented range animation#3331
Merged
offtherailz merged 2 commits intogeosolutions-it:c127_geonode_integrationfrom Nov 15, 2018
Merged
Fix #3282. Implemented range animation#3331offtherailz merged 2 commits intogeosolutions-it:c127_geonode_integrationfrom
offtherailz merged 2 commits intogeosolutions-it:c127_geonode_integrationfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request implements range animation.
Now the currentTime and offsetTime are centralized in
dimensionreducer. The presence of offsetTime is the flag to understand if the mode is ranged or single time.Implemented a MOVE_TIME action that moves allow to move the current time, if an offsetTime is present, it will be shifted together with current time.
Another major change is about initialization. If the user clicks on "range" button, the missing required variables in state will be initialized :
dimension.currentTimeanddimension.offsetTime(extremities of the range)Issues
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
What is the current behavior? (You can also link to an open issue here)
Range can not be animated
What is the new behavior?
Range can be animated
Does this PR introduce a breaking change? (check one with "x", remove the other)
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: