Fix #3279. Added settings form for timeline #3328
Merged
offtherailz merged 2 commits intogeosolutions-it:c127_geonode_integrationfrom Nov 12, 2018
Merged
Fix #3279. Added settings form for timeline #3328offtherailz merged 2 commits intogeosolutions-it:c127_geonode_integrationfrom
offtherailz merged 2 commits intogeosolutions-it:c127_geonode_integrationfrom
Conversation
Contributor
|
Generally we will have a guiding layer that will dictate the animation steps. I suppose the "Following" option is for that, but I would make it more automated. IMHO the "Following" option is not needed: if a guide layer is selected the amination automatically follows it. |
Contributor
|
so @offtherailz, to resume the "Fixed step" behaviours:
The "Following" remains because it's about following marker while animating... |
Member
Author
|
All correct, please move your comment in the issue for the effective implementation, here: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces settings form for animation settings of timeline/playback plugin. This is only the UI (connected with the state), but the functionalities, of course, have yet to be implemented.
Also added i18n for the 2 plugins, that was missing.
Issues
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
What is the current behavior?
Playback settings window was a draft
What is the new behavior?
Playback settings window contains all the settings that need to be implemented.
Does this PR introduce a breaking change?