Skip to content

Widget Builder and Catalog are not contained in Map Viewer of API#3327

Merged
allyoucanmap merged 3 commits intogeosolutions-it:c127_geonode_integrationfrom
allyoucanmap:embedded-panels
Nov 12, 2018
Merged

Widget Builder and Catalog are not contained in Map Viewer of API#3327
allyoucanmap merged 3 commits intogeosolutions-it:c127_geonode_integrationfrom
allyoucanmap:embedded-panels

Conversation

@allyoucanmap
Copy link
Copy Markdown
Contributor

Description

Updated widget builder and metadata explorer panel container

Issues

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Feature

What is the current behavior? (You can also link to an open issue here)
issue #3326

What is the new behavior?

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@coveralls
Copy link
Copy Markdown

coveralls commented Nov 12, 2018

Coverage Status

Coverage increased (+0.004%) to 80.889% when pulling 8eb2503 on allyoucanmap:embedded-panels into 704ae99 on geosolutions-it:c127_geonode_integration.

onFullscreen = () => {},
fixed = false
fixed = false,
hideHeader
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would call it showHeader with the logic inverted, but this is subjective, isn't it? @offtherailz @mbarto

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would leave it as is

@MV88 MV88 changed the title Widget Builder and Catalog are not conatined in Map Viewer of API Widget Builder and Catalog are not contained in Map Viewer of API Nov 12, 2018
@allyoucanmap allyoucanmap merged commit 34606fb into geosolutions-it:c127_geonode_integration Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants