Skip to content

Update Croatian translation#3166

Merged
mbarto merged 1 commit intogeosolutions-it:masterfrom
dracic:hr-HR-translation-update
Aug 22, 2018
Merged

Update Croatian translation#3166
mbarto merged 1 commit intogeosolutions-it:masterfrom
dracic:hr-HR-translation-update

Conversation

@dracic
Copy link
Copy Markdown
Contributor

@dracic dracic commented Aug 21, 2018

Description

Update Croatian translation. Contains changes 28.03.2018 -> 20.08.2018.

Issues

  • Fix #
  • ...

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe: Translation

What is the current behavior? (You can also link to an open issue here)

What is the new behavior?

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-25.3%) to 55.64% when pulling 497d7fb on dracic:hr-HR-translation-update into ce0f7c2 on geosolutions-it:master.

@dracic
Copy link
Copy Markdown
Contributor Author

dracic commented Aug 21, 2018

I don't think that this CI build fail has to do with translation update. Any suggestion?

@mbarto
Copy link
Copy Markdown
Contributor

mbarto commented Aug 21, 2018

I don't think either. I will check tomorrow morning. Thanks for the contribution. By the way I was in Croatia last week. Very nice places.

@dracic
Copy link
Copy Markdown
Contributor Author

dracic commented Aug 22, 2018

@mbarto, I hope you've had a great time too. 😁

@dracic
Copy link
Copy Markdown
Contributor Author

dracic commented Aug 22, 2018

FYI. Yesterday I had one fail locally (Fedora 28, Karma on Chrome) similar to this one on Github, but than two times with no changes:

✔ 3074 tests completed
⚠ 35 tests slow

With a bunch of errors related to NumberPicker component:

ERROR: 'Warning: setState(...): Can only update a mounted or mounting component. This usually means you called setState() on an unmounted component. This is a no-op. Please check the code for the NumberPicker component.'

Also I tried it now withe the same result.

@mbarto
Copy link
Copy Markdown
Contributor

mbarto commented Aug 22, 2018

We have some randomly failing tests that bother us (mainly time-dependent tests that sometimes take too long to complete), so I wouldn't worry. I have just relaunched Travis-CI, but I am going to merge it after that, because it looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants