adding percentage in tooltip#3151
Merged
offtherailz merged 5 commits intogeosolutions-it:masterfrom Aug 10, 2018
Merged
Conversation
offtherailz
requested changes
Aug 8, 2018
…to baloola-tooltip_pie
offtherailz
requested changes
Aug 10, 2018
Member
offtherailz
left a comment
There was a problem hiding this comment.
This is ugly
I prefer something like this:
I'll send you a PR for this changes, please adjust tests if needed.
Contributor
Author
|
this change will not affect the unit test |
Baloola tooltip pie
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This Pr adds a customized tooltip that also renders the percentage of the " active " pie segment
Issues
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
What is the current behavior? (You can also link to an open issue here)
see #2651
What is the new behavior?
when the mouse hover the pie segment the tooltip shows the percentage
Does this PR introduce a breaking change? (check one with "x", remove the other)
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: