Skip to content

Fix #3051 toc group/layers problems#3141

Merged
tdipisa merged 2 commits intogeosolutions-it:masterfrom
MV88:3051_toc_problems
Sep 27, 2018
Merged

Fix #3051 toc group/layers problems#3141
tdipisa merged 2 commits intogeosolutions-it:masterfrom
MV88:3051_toc_problems

Conversation

@MV88
Copy link
Copy Markdown
Contributor

@MV88 MV88 commented Aug 3, 2018

Description

This pr fixes some issues on the toc: on related to the way new groups are added and one on the delete of the layers and all the group hiearchy that has no layers in the sub-tree

  • By doing that it also accomplish the group deletion if all layers of that group are selected and you hit delete all the levels trash button (maybe we can change the name with "Delete all the layers and groups"
  • Maybe we can make the regex used to filter which groups name can be created configurable.
    @tdipisa opinions?

Issues

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

What is the new behavior?
It is not possible to create group with empty name.
if you delete a layer in a subgroup and no layers are left then all the group hierarchy is deleted along with the layer

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:
I've added a TocUtils for all the stuff that is toc related

@MV88 MV88 self-assigned this Aug 3, 2018
@MV88 MV88 requested a review from mbarto August 3, 2018 09:20
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.06%) to 80.913% when pulling 152631f on MV88:3051_toc_problems into 6727203 on geosolutions-it:master.

@tdipisa tdipisa added this to the 2018.02.01 milestone Sep 27, 2018
@tdipisa tdipisa self-requested a review September 27, 2018 08:42
Copy link
Copy Markdown
Member

@tdipisa tdipisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MV88, this needs a PR to be backported to the stable branch 2018.02.xx too.
This needs to be done before the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug in Creating and Managing Layer Groups

4 participants