Fix #1997: Make home page handle forward slashes#3041
Merged
offtherailz merged 8 commits intogeosolutions-it:masterfrom Aug 9, 2018
Merged
Fix #1997: Make home page handle forward slashes#3041offtherailz merged 8 commits intogeosolutions-it:masterfrom
offtherailz merged 8 commits intogeosolutions-it:masterfrom
Conversation
offtherailz
requested changes
Jun 29, 2018
Member
There was a problem hiding this comment.
- The same problem is for every reserved char
; / ? : @ = &. Please remove also this from the string. - Write a unit test
note: This is a thunk. It is an old system we used to perform async operation, before the epics. If testing is to hard you may replace loadMaps with a pure action and create a new epic to replace this thunk's logic.
- converted impure function(thunk) to pure function which returns an action - Added an loadMap Epic and MAPS_LOAD_MAP action - Added getMapsResourcesByCategory Epic and MAPS_GET_MAP_RESOURCES_BY_CATEGORY - Made sesrch handle reserved special characters
- Added test for getMapsResourcesByCategoryEpic - Added test for loadMapsEpic
offtherailz
approved these changes
Aug 9, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Made home page handle forward slashes
Issues
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Does this PR introduce a breaking change? (check one with "x", remove the other)