fix #2861 extra scrollbar when dragging down layer metadata modal#2933
Merged
MV88 merged 3 commits intogeosolutions-it:masterfrom May 21, 2018
Merged
fix #2861 extra scrollbar when dragging down layer metadata modal#2933MV88 merged 3 commits intogeosolutions-it:masterfrom
MV88 merged 3 commits intogeosolutions-it:masterfrom
Conversation
offtherailz
reviewed
May 21, 2018
| @@ -1,3 +1,7 @@ | |||
| #container { | |||
| overflow: hidden; | |||
Member
There was a problem hiding this comment.
Too generic. This set overflow: hidden to every #container HTML element. That's very dangerous. Is there any other solution?
offtherailz
reviewed
May 21, 2018
| @@ -1,3 +1,7 @@ | |||
| #container { | |||
| overflow: hidden; | |||
Member
There was a problem hiding this comment.
Too generic. This is very dangerous. Every element with id ='container' will not have scrolling anymore. I suggest you to use a less generic css selector and use the Portal element. For instance a class called fill-portal that solves this issue
some hints:
look at :
- z-index
- pointer-events css class (See dashboard)
offtherailz
reviewed
May 21, 2018
Member
offtherailz
left a comment
There was a problem hiding this comment.
Please use the portal props instead of global one
Contributor
Author
|
position:fixed has fixed the problem 💃 |
offtherailz
approved these changes
May 21, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
it appears a scrollbar to the whole body when dragging down the layer metadata modal
Issues
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
What is the current behavior? (You can also link to an open issue here)
see description
What is the new behavior?
scrollbar no longer appears
Does this PR introduce a breaking change? (check one with "x", remove the other)
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: