Skip to content

Fix circle bugs and added other improvements#2744

Merged
MV88 merged 2 commits intogeosolutions-it:c125_annotationsfrom
MV88:fix_circle_bugs
Mar 15, 2018
Merged

Fix circle bugs and added other improvements#2744
MV88 merged 2 commits intogeosolutions-it:c125_annotationsfrom
MV88:fix_circle_bugs

Conversation

@MV88
Copy link
Copy Markdown
Contributor

@MV88 MV88 commented Mar 14, 2018

Description

see notes on linked issue

Issues

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

  • styler tool has a too specific tooltip
  • there is a bug when drawing a line and then a polygon
  • the form is disabled when drawing

What is the new behavior?

  • now the styler tool has a more generic tooltip

  • there is no bug when drawing a line and then a polygon

  • the form is not disabled when drawing
    Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes

  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@coveralls
Copy link
Copy Markdown

coveralls commented Mar 14, 2018

Coverage Status

Coverage decreased (-0.004%) to 79.023% when pulling d3f4c65 on MV88:fix_circle_bugs into 2c4d30b on geosolutions-it:c125_annotations.

@ghost ghost removed the pending review label Mar 14, 2018
@MV88 MV88 merged commit 7c2862d into geosolutions-it:c125_annotations Mar 15, 2018
@ghost ghost removed In Test review labels Mar 15, 2018
@chiaracurcio chiaracurcio self-assigned this Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants