Allow animation disable to support vertical toolbars#2693
Merged
mbarto merged 3 commits intogeosolutions-it:masterfrom Mar 12, 2018
Merged
Allow animation disable to support vertical toolbars#2693mbarto merged 3 commits intogeosolutions-it:masterfrom
mbarto merged 3 commits intogeosolutions-it:masterfrom
Conversation
Member
Author
|
During latest developments a vertical toolbar has been created.
Note: during development the button number may change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bootstrap manages vertical toolbars using a css rule with ">".
Current
misc/Toolbarcomponent introducesReactCSSAnimationGroupinside the toolbar, that produces an internalspanelement. This difference make the css rules for vertical toolbar not valid.This pull requests make the animation group optional for this reason.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior?
Does this PR introduce a breaking change? (check one with "x", remove the other)