Fixes #2605 Improve iframe on react quill textarea#2641
Merged
mbarto merged 8 commits intogeosolutions-it:masterfrom Mar 12, 2018
Merged
Fixes #2605 Improve iframe on react quill textarea#2641mbarto merged 8 commits intogeosolutions-it:masterfrom
mbarto merged 8 commits intogeosolutions-it:masterfrom
Conversation
offtherailz
requested changes
Feb 26, 2018
Member
offtherailz
left a comment
There was a problem hiding this comment.
Check if you can increase test coverage.
|
|
||
| return { | ||
| ResizeModule, | ||
| Video, |
| const {ResizeModule, Video, toolbarConfig} = require('../../../misc/quillmodules/ResizeModule')(Quill); | ||
|
|
||
| Quill.register({ | ||
| 'formats/video': Video, |
Member
There was a problem hiding this comment.
import Iframe, explicit why formats/video is needed
| - Added resize on iframe | ||
| - Added new Video format | ||
| - Basic toolbar configuration of container | ||
| - exported as function to use current Quill (not window.Quill) |
Member
There was a problem hiding this comment.
doc somehow to use formats/video
offtherailz
reviewed
Feb 27, 2018
Member
offtherailz
left a comment
There was a problem hiding this comment.
quillmodules folder should go in another directory (it is not a coponent). But may be ok for the moment
offtherailz
approved these changes
Feb 28, 2018
This was referenced Sep 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added quill module to improve resize and editing of iframe components.
Issues
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
What is the current behavior? (You can also link to an open issue here)
Currently iframe/video aren't resizable and editable on react quill
What is the new behavior?
Now iframe/video are resizable and editable on react quill
Does this PR introduce a breaking change? (check one with "x", remove the other)
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: