Geodashboard skeleton with text widget#2594
Merged
offtherailz merged 29 commits intogeosolutions-it:masterfrom Feb 13, 2018
Merged
Geodashboard skeleton with text widget#2594offtherailz merged 29 commits intogeosolutions-it:masterfrom
offtherailz merged 29 commits intogeosolutions-it:masterfrom
Conversation
- Support for shared state for widgets and widget builder - Auto recognize if a layer is selected to prompt catalog for layer's choice
- Catalog selector (WIP) - Notification for layer selected that doesn't allow the charts - localizedProps enhancer - Retrieve wms describelayer and add wfs url - Improved wizard style (catalog) - small bugfixes/adjustments
- Some improvements to the catalog - Reorganized loading spinners and views
MV88
requested changes
Feb 9, 2018
| () => ({ | ||
| glyph: "dashboard", | ||
| title: "The dashboard is empty" // TODO i18n | ||
| }) |
mbarto
reviewed
Feb 9, 2018
web/client/actions/dashboard.js
Outdated
| @@ -0,0 +1,8 @@ | |||
| const SET_EDITOR_AVAILABLE = "DASHBOARD:SET_AVAILABLE"; | |||
| const SET_EDITING = "DASHBOARD:SET_EDITOR_AVAILABLE"; | |||
Contributor
There was a problem hiding this comment.
SET_EDITING, not SET_EDITOR_AVAILABLE
| */ | ||
| const {compose} = require('recompose'); | ||
| const deleteWidget = require('./deleteWidget'); | ||
| module.exports = compose( |
Member
Author
There was a problem hiding this comment.
Yes, compose only one enhancer is unnecessary
| monitoredState: PluginsUtils.getMonitoredState(state, ConfigUtils.getConfigProp('monitorState')) | ||
| }))(require('../components/plugins/PluginsContainer')); | ||
|
|
||
| class HolyGrail extends React.Component { |
Member
Author
There was a problem hiding this comment.
Contributor
|
In general, it looks difficult to review such big PRs |
Member
Author
|
Yes I know is a little hard, but I had to reorganize a lot of file to do that. Please take a look to the P.R. information to get the points you can focus on. |
- Add translations for empty dashboard - Fixed test that fail - Fixed wrong constant strings - clean up of the text widget
MV88
approved these changes
Feb 13, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With this pull request we have a first skeleton of a geodashboard, to add features as for the mockup.
The dashboard is accessible at #dashboard of the demo and supports charts and text widgets.
Issues
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Feature
Does this PR introduce a breaking change? (check one with "x", remove the other)
No
Other information:
This pull request contain many changes so a small guide can be useful for the review:
general:
localizePropsenhancer that allows to replace a msgId string with the localized string in props (for some components that need strings and not messages, like the inputplaceholderwidgets builder:
catalog (for widget builder):
page layout:
HolyGrailplugin container that allow to render plugins in a borderlayout, so the plugins can be rendered into different areas via configuration. This is needed for the current dashboard and the future new home page