DrawSupport:Replace does not add drawinteraction by default#2581
Merged
mbarto merged 2 commits intogeosolutions-it:masterfrom Mar 8, 2018
Merged
DrawSupport:Replace does not add drawinteraction by default#2581mbarto merged 2 commits intogeosolutions-it:masterfrom
mbarto merged 2 commits intogeosolutions-it:masterfrom
Conversation
Contributor
|
The PR looks good. Any chance you can add a unit test? |
Contributor
Author
|
Ok for the unit test. I will update the pr when it's done 📦 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hi,
This PR change a little bit the drawsupport replace function as proposed here https://groups.google.com/forum/#!topic/mapstore-developers/s3A77gAHleU
It add the possibility to choose to add interactions whit the drawEnabled option. By default, it's false.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
What is the current behavior? (You can also link to an open issue here)
DrawSupport : When the draw layer is not defined and replace function is called. The draw layer is initialized with draw interactions by default : call to add layer with True hardcoded
What is the new behavior?
DrawSupport : When the draw layer is not defined and replace function is called. The draw layer is NOT initialized with draw interactions by default : call to add layer use options.drawEnabled parameter. By default the value is False/
Does this PR introduce a breaking change? (check one with "x", remove the other)
This PR may introduce breaking change. As described before the current behavior is to add by default the interactions when using replace. And this PR set the default to false. If it is not possible or correct to use "False" by default , i can change this PR to have the same default behaviour
Other information:
If tests case are needed, please let me know