Skip to content

First implementation of map widgets#2405

Merged
offtherailz merged 45 commits intogeosolutions-it:masterfrom
offtherailz:widgets
Nov 21, 2017
Merged

First implementation of map widgets#2405
offtherailz merged 45 commits intogeosolutions-it:masterfrom
offtherailz:widgets

Conversation

@offtherailz
Copy link
Copy Markdown
Member

@offtherailz offtherailz commented Nov 16, 2017

Description

This provides a first implementation of map widgets (charts) functionality.
See the mockup for details

Issues

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Feature

What is the current behavior? (You can also link to an open issue here)
No charts available

What is the new behavior?
You can add charts to the map as in the Mockup.

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • No

Other information:

  • The missing things to improve functionalities are listed in the related issue
  • The query builder is now more usable for general purposes (not 2 way binded to the WFS query)
  • Important Note: This pull request introduces and uses some HOCs that should be used everywere, to provide a more consistent interface and simplify/speed up development:
    • emptyState: shows an empty state view (like this) instead of the component, providing a test function. Tj
    • loadingState: shows a loading spinner instead of the component. By default gets the loading prop but supports also a test function.
    • propsStreamFactory: allow to provide a function as argument of a component that generates the properties of the component it is applied: useful to make reusable widgets that do complex async data flows.

mricca and others added 30 commits October 13, 2017 15:39
@mricca
Issue geosolutions-it#2285 Allow customization of GetFeatureInfo visu…
0109a66 
…alization per layer
@mricca
Various Fixes
3852352
@offtherailz
Aligned widgets tool to master branch
92714c1
@offtherailz
initial setup of floating charts
88a54d9
@offtherailz
Merge branch 'mapstore2_featureInfo_propTab' of https://github.com/mr…
f70bd95 
…icca/MapStore2 into widgets
@offtherailz
Merge branch 'master' of https://github.com/geosolutions-it/MapStore2 …
ae20cea 
…into widgets
@offtherailz
Work in progress
bf7f61b
@offtherailz
WIP
46d9f05
@offtherailz
WIP
80d9eca
@offtherailz
WIP
3718b46
@offtherailz
Merge branch 'master' into widgets
f62c66c
@offtherailz
WIP
49f5ad1
@offtherailz
add auto toolbar setup of widgets
9a5d7a2
@offtherailz
Merge branch 'master' into widgets
8dfc1ac
@offtherailz
improved UI and auto service inspection
573b12e
@offtherailz
extact map options to save from plugins
b59ba91
@offtherailz
fixed issue about css background in feature editor
e61edc9
@offtherailz
Automatic sorting for data in charts
3325b94
@offtherailz
improved color range selector
4f3d27c
@offtherailz
save and restore layout
35628f7
@offtherailz
Integration of query panel and other improvements
5de1ddd 
 - Integrated query panel to edit a filter for the widget editor
 - Improved UI to show the preview in live sync, the selected type
 - Management of the geometry filter mixing query builder's and map one
@offtherailz
Reorganized style. Setup initial widget position and collision
b3340cd
@offtherailz
implemented image export and fixed resize issues. Minor style changes
e16ba3e
@offtherailz
Merge branch 'master' of https://github.com/geosolutions-it/MapStore2 …
8ed7719 
…into widgets_merge
@offtherailz
Add italian translation
340f71a
@offtherailz
Merge branch 'master' of https://github.com/geosolutions-it/MapStore2 …
12fe90a 
…into widgets_merge
@offtherailz
Various improvements to widgets
3f72da4 
 - Layout management
 - Error management inside widgets
 - Translations updated
 - Some improvements to color selector
@offtherailz
First set of unit tests. Removed some react-key warnings
752ee92
@offtherailz
Merge branch 'master' into widgets
2ebed8a
@offtherailz
added more unit tests
fd1bac3
@coveralls
Copy link
Copy Markdown

coveralls commented Nov 16, 2017

Coverage Status

Coverage increased (+0.3%) to 81.006% when pulling 88fc23d on offtherailz:widgets into dff8fb5 on geosolutions-it:master.

@geosolutions-it geosolutions-it deleted a comment Nov 17, 2017
@mbarto
Copy link
Copy Markdown
Contributor

mbarto commented Nov 17, 2017

Some comments:

  • Esporta dati --> Scarica immagine
  • delete confirm dialog --> not translated (in italian at least)
  • line and histo charts --> colors are not updated on combo selection
  • missing title / help button in gauge dialog

@coveralls
Copy link
Copy Markdown

coveralls commented Nov 17, 2017

Coverage Status

Coverage increased (+0.3%) to 81.007% when pulling 33547ac on offtherailz:widgets into ddeaa57 on geosolutions-it:master.

@geosolutions-it geosolutions-it deleted a comment Nov 17, 2017
@coveralls
Copy link
Copy Markdown

coveralls commented Nov 17, 2017

Coverage Status

Coverage increased (+0.3%) to 81.007% when pulling 87e1264 on offtherailz:widgets into ddeaa57 on geosolutions-it:master.

@geosolutions-it geosolutions-it deleted a comment Nov 17, 2017
@coveralls
Copy link
Copy Markdown

coveralls commented Nov 17, 2017

Coverage Status

Coverage increased (+0.4%) to 81.072% when pulling 756a4d9 on offtherailz:widgets into ddeaa57 on geosolutions-it:master.

@offtherailz
Some minor fixes and improvements
15868c2 
 - Now the color selection works also for lines and bars
 - Wizard button moved to the top
 - Improved error management. Now a chart that returns error can not be completed.
@coveralls
Copy link
Copy Markdown

coveralls commented Nov 21, 2017

Coverage Status

Coverage increased (+0.4%) to 81.06% when pulling 15868c2 on offtherailz:widgets into ddeaa57 on geosolutions-it:master.

@coveralls
Copy link
Copy Markdown

coveralls commented Nov 21, 2017

Coverage Status

Coverage increased (+0.3%) to 80.977% when pulling a203383 on offtherailz:widgets into ddeaa57 on geosolutions-it:master.

@offtherailz offtherailz merged commit 4a3c085 into geosolutions-it:master Nov 21, 2017
@offtherailz offtherailz deleted the widgets branch February 18, 2020 11:56
@allyoucanmap allyoucanmap mentioned this pull request Aug 9, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mbarto mbarto Awaiting requested review from mbarto

Assignees

@offtherailz offtherailz

Labels

C040-2020-COMUNE_GE-SUPPORT

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@offtherailz @coveralls @mbarto @tdipisa @mricca