Skip to content

build: upgrade to jdk11 -> jdk17 for bundled jre#11693

Merged
offtherailz merged 2 commits intogeosolutions-it:masterfrom
mahesh-wor:build-jdk-17-upgrade
Dec 17, 2025
Merged

build: upgrade to jdk11 -> jdk17 for bundled jre#11693
offtherailz merged 2 commits intogeosolutions-it:masterfrom
mahesh-wor:build-jdk-17-upgrade

Conversation

@mahesh-wor
Copy link
Copy Markdown
Contributor

@mahesh-wor mahesh-wor commented Nov 17, 2025

Description

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

What is the current behavior?
Earlier the jre bundle was being downloaded from dropbox url for jdk 11.
Apache docker image was using tomcat:9-jdk11

What is the new behavior?
New jdk17 bundle (win/linux) are fetched from https://maven.geo-solutions.it/jdk/17.0.13/
Apache docker image updated to usetomcat:9-jdk17

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No
  • Locally Tested, Further to be verified with Github Actions build jobs.

Other useful information

@tdipisa tdipisa requested a review from offtherailz November 21, 2025 14:11
@tdipisa tdipisa added this to the 2026.01.00 milestone Nov 21, 2025
@tdipisa tdipisa added deploy needed dependencies Pull requests that update a dependency file DevOps labels Nov 21, 2025
@tdipisa tdipisa linked an issue Nov 21, 2025 that may be closed by this pull request
Documentation about requirements need some updating #11714
Closed
2 tasks
@offtherailz offtherailz removed a link to an issue Nov 24, 2025
Documentation about requirements need some updating #11714
Closed
2 tasks
offtherailz
offtherailz requested changes Nov 24, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@offtherailz offtherailz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that, if we go to Java 17,

  • also the documentation should be upgraded accordingly (Suggsted version, consistent with the one used. On master doc for 2026.01 is the max version)
  • Build, test runs etc... should run with Java 17. About this, we have this PR that should be merged (first). Anyway this requires all the pending PR to be updated.

For these reason I suggest to

  • Update the doc with versions (on this PR)
  • wait for PR to be merged <-- for this I suggest to do a recheck of PR pendings immediately after 2025.02.02 release.

P.S. I removed the link to documentation fix because this doesn't fix it, and it refers to another PR. Probably an error @tdipisa

@mahesh-wor
Copy link
Copy Markdown
Contributor Author

mahesh-wor commented Dec 2, 2025

Waiting for PR to be merged, Will then rebase with master > update docs/developer-guide/requirements.md > Check build status with matrix implementation.
Then we can merge it.
@offtherailz

@tdipisa
Copy link
Copy Markdown
Member

tdipisa commented Dec 2, 2025

Waiting for PR to be merged,

Thank you @mahesh-wor. Let's wait for v2025.02.00 to be out next week before merging that.

@tdipisa tdipisa requested a review from offtherailz December 15, 2025 15:19
@tdipisa
Copy link
Copy Markdown
Member

tdipisa commented Dec 15, 2025

Waiting for PR to be merged, Will then rebase with master > update docs/developer-guide/requirements.md > Check build status with matrix implementation. Then we can merge it. @offtherailz

@mahesh-wor v2025.02.00 is released. You can now proceed with that.

@mahesh-wor
Copy link
Copy Markdown
Contributor Author

mahesh-wor commented Dec 17, 2025

Hi @tdipisa , seems like the Dockerfile and build stuff is changed from my last PR in master, i will do some test builds runs and update here.

@randomorder
Copy link
Copy Markdown
Member

randomorder commented Dec 17, 2025

Hi @tdipisa , seems like the Dockerfile and build stuff is changed from my last PR in master, i will do some test builds runs and update here.

@mahesh-wor get in touch with brian if you have questions

@mahesh-wor
Copy link
Copy Markdown
Contributor Author

mahesh-wor commented Dec 17, 2025

@offtherailz Hi tested local build with the changes i made, also updated java/jdk recommendation to v17.

FYI: We did an upgrade to postgres db version to Postgres 17 for Mapstore2 in this issue, but i see that the docker-compose has FROM postgis/postgis:12-3. and docs recommends postgres 13, minimum.

@tdipisa
Copy link
Copy Markdown
Member

tdipisa commented Dec 17, 2025

FYI: We did an upgrade to postgres db version to Postgres 17 for Mapstore2 in this issue, but i see that the docker-compose has FROM postgis/postgis:12-3. and docs recommends postgres 13, minimum.

@mahesh-wor it was purpose of internal https://github.com/geosolutions-it/internal/issues/426 to provide the setup for PGSQL 16 or 17. Therefore, you have to provide all necessary pending changes with a new PR, I suppose. Can you raise it? We have to ensure all is aligned.

offtherailz
offtherailz reviewed Dec 17, 2025
View reviewed changes
docs/developer-guide/requirements.md
| npm | [link](https://www.npmjs.com/get-npm) | 8 | 10 | |
| NodeJS | [link](https://nodejs.org/en/) | 20 | 20 | 25<sup>3</sup> |
| Java (JDK) | [link](https://www.java.com/en/download/help/develop.html) | 8 | 11 | 17 |
| Java (JDK) | [link](https://www.java.com/en/download/help/develop.html) | 8 | 17 | 17 |
Copy link
Copy Markdown
Member

@offtherailz offtherailz Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| Java (JDK) | [link](https://www.java.com/en/download/help/develop.html) | 8 | 17 | 17 |
| Java (JDK) | [link](https://www.java.com/en/download/help/develop.html) | 8 | 17 | 21 |

offtherailz
offtherailz approved these changes Dec 17, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@offtherailz offtherailz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@randomorder and @mahesh-wor
If we are going to use 17 from now on for 2026.01, we should start to use it on dev build / docker / server too, so tests can be done using the suggested version

@offtherailz offtherailz merged commit 262ff3f into geosolutions-it:master Dec 17, 2025
18 checks passed
@offtherailz offtherailz mentioned this pull request Dec 17, 2025
Merged
12 tasks
@offtherailz
Copy link
Copy Markdown
Member

offtherailz commented Dec 18, 2025

Docker build failed @mahesh-wor . going to reopen the issue.

@mahesh-wor
Copy link
Copy Markdown
Contributor Author

mahesh-wor commented Dec 18, 2025 

ERROR: failed to build: failed to solve: tomcat:9-jdk17: failed to authorize: failed to fetch oauth token: unexpected status from POST request to https://auth.docker.io/token: 500 Internal Server Error

Seems like something wrong with https://auth.docker.io/token, Error 500.
I tested the key on the runner machine just now and there is no pull error, removing the image and rebuilding. Let's see if it works.

If it does not work, will investigate further.

@mahesh-wor
Copy link
Copy Markdown
Contributor Author

mahesh-wor commented Dec 18, 2025 •
edited
Loading 

e5ade416e6d9: Pushed
baa3b6db37e5: Pushed
301589a7c094: Pushed
d3e3925959bc: Mounted from library/tomcat
be1d5d5aa9ea: Mounted from library/tomcat
db1688142012: Mounted from library/tomcat
d03939930dac: Mounted from library/tomcat
35c0b8fb11b1: Mounted from library/tomcat
e8bce0aabd68: Layer already exists
d7ef4463791e: Mounted from library/tomcat
79a638aab349: Pushed
6cfff8db9bd5: Pushed
841ca107cc80: Pushed
master-dev: digest: sha256:6893e2e564373b70df601ad85baf4f5033541731bedc72573e9f06b95eb1d8d1 size: 4290
Archiving artifacts
Sending e-mails to: mapstore@geosolutionsgroup.com
Started calculate disk usage of build
Finished Calculation of disk usage of build in 0 seconds
Started calculate disk usage of workspace
Finished Calculation of disk usage of workspace in  3 second
Triggering a new build of MapStore » MapStore2-Dev-EndPointTests
Finished: SUCCESS

@offtherailz It's working now, I didn't change a thing.
DockerHub had degraded performance issued yesterday. Could be that.
https://www.dockerstatus.com/pages/history/533c6539221ae15e3f000031

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@offtherailz offtherailz offtherailz approved these changes

@randomorder randomorder Awaiting requested review from randomorder

Assignees

@offtherailz offtherailz

@randomorder randomorder

Labels

dependencies Pull requests that update a dependency file deploy needed DevOps MapStore

Projects

None yet

Milestone

2026.01.00

Development

Successfully merging this pull request may close these issues.

4 participants

@mahesh-wor @tdipisa @randomorder @offtherailz