Skip to content

[#11205] MapStore war stand-alone not starting#11207

Merged
tdipisa merged 3 commits intomasterfrom
ISSUE_11205
Jun 16, 2025
Merged

[#11205] MapStore war stand-alone not starting#11207
tdipisa merged 3 commits intomasterfrom
ISSUE_11205

Conversation

@afabiani
Copy link
Copy Markdown
Member

@afabiani afabiani commented Jun 16, 2025

Description

Adds back the httpcore dependency which was excluded because of a duplication on the printing plugin.

It also excludes the conflicting version on the printing plugin.

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

What is the current behavior?

#11205

What is the new behavior?

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@afabiani afabiani requested a review from tdipisa June 16, 2025 11:26
@afabiani afabiani self-assigned this Jun 16, 2025
@tdipisa tdipisa requested a review from offtherailz June 16, 2025 12:27
@tdipisa tdipisa added this to the 2025.01.00 milestone Jun 16, 2025
@tdipisa tdipisa linked an issue Jun 16, 2025 that may be closed by this pull request
1 task
@tdipisa tdipisa linked an issue Jun 16, 2025 that may be closed by this pull request
1 task
@tdipisa tdipisa added the ci/cd label Jun 16, 2025
Copy link
Copy Markdown
Member

@offtherailz offtherailz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that the duplication of httpcore 4.4.13 and 4.4.15 may give no issues, I'd approve it.

pom.xml Outdated
<version>${metrics.version}</version>
<type>pom</type>
<scope>import</scope>
<exclusions>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@afabiani if not necessary, better to remove it. As agreed waiting for you further update for adding the exclusion in the printing module.

@tdipisa tdipisa self-requested a review June 16, 2025 14:19
@tdipisa tdipisa enabled auto-merge (squash) June 16, 2025 14:23
@tdipisa tdipisa merged commit 9ab483a into master Jun 16, 2025
5 checks passed
@tdipisa tdipisa deleted the ISSUE_11205 branch June 16, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MapStore war stand-alone not starting

3 participants