Skip to content

Menu divider border style#10997

Merged
allyoucanmap merged 2 commits intogeosolutions-it:geonode-homefrom
dsuren1:navbar_divider
Apr 8, 2025
Merged

Menu divider border style#10997
allyoucanmap merged 2 commits intogeosolutions-it:geonode-homefrom
dsuren1:navbar_divider

Conversation

@dsuren1
Copy link
Copy Markdown
Contributor

@dsuren1 dsuren1 commented Apr 8, 2025

Description

This PR adds the menu divider border style

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Enhancement

Issue

What is the current behavior?

What is the new behavior?
Menu divider has style of 1px border
image

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@dsuren1 dsuren1 added this to the 2025.01.00 milestone Apr 8, 2025
@dsuren1 dsuren1 requested a review from allyoucanmap April 8, 2025 12:49
@dsuren1 dsuren1 self-assigned this Apr 8, 2025
@dsuren1
Copy link
Copy Markdown
Contributor Author

dsuren1 commented Apr 8, 2025

@allyoucanmap
Should we use 0.5px border instead?

with 0.5px (it matches width 1px)
image

with 1px
image

@dsuren1 dsuren1 changed the title Add divider border style Add menu divider border style Apr 8, 2025
@dsuren1 dsuren1 changed the title Add menu divider border style Menu divider border style Apr 8, 2025
@allyoucanmap allyoucanmap merged commit 7b759ae into geosolutions-it:geonode-home Apr 8, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants