Fix #10473 support of autoDetectCORS for 3D tiles#10474
Closed
offtherailz wants to merge 1 commit intogeosolutions-it:masterfrom
Closed
Fix #10473 support of autoDetectCORS for 3D tiles#10474offtherailz wants to merge 1 commit intogeosolutions-it:masterfrom
offtherailz wants to merge 1 commit intogeosolutions-it:masterfrom
Conversation
6 tasks
6 tasks
Member
|
@allyoucanmap @offtherailz I think this can be closed in favor of #10526. Isn't it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This draft PR (missing tests and maybe need more options to discuss) is a work in progress and a proof of concept that tries to solve #10473.
In this PR I was able to check performances on 3D tiles now (that use CORS by default, when not specified in
useCORS) and the implementation withautoDetectCORS.Because of the results in terms of performances, I think we need to consider this or alternative solutions that use cors on 3D stuff (See other informations).
Things to do:
autoDetectCORSis now supported, if Improved documentation for autoDetectCORS, tileSize and singleTiles #10472 is mergedPlease check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#
What is the new behavior?
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information
I tested this map
https://dev-mapstore.geosolutionsgroup.com/mapstore/#/viewer/42750
applying locally this fix compared, noticed a double speed in loading 3D tiles in same conditions.
Locally we have 2 proxies that loads slowly, but it took:
To load all the 3D meshes. In production it already takes, with the proxy, something like 30 seconds, so we may encounter some greater improvements.
I wasn't able to replicate the same effect including the URL in useCORS, for some reason setting it, it fails, but with this fix, it looks to correctly load the tiles.
I think this is a performance improvement we need to take into account. We may change this bahavior to allow an autoDetectCORS in layers too.