Skip to content

#10235: Interactive legend in dashboard and geostory#10426

Merged
allyoucanmap merged 1 commit intogeosolutions-it:masterfrom
mahmoudadel54:feature_10235
Jun 17, 2024
Merged

#10235: Interactive legend in dashboard and geostory#10426
allyoucanmap merged 1 commit intogeosolutions-it:masterfrom
mahmoudadel54:feature_10235

Conversation

@mahmoudadel54
Copy link
Copy Markdown
Contributor

@mahmoudadel54 mahmoudadel54 commented Jun 14, 2024

Description

In this PR, these points are implemented:

  • Handling showing interactive legend option for dashboard and geostory
  • Handle saving layerFilter for dashboard and geostory
  • Add refactoring to StyleBasedWMSJsonLegend

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

#10235

What is the current behavior?
#10235

What is the new behavior?
Now user can filter by legend within dashboards and geostories

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@mahmoudadel54
geosolutions-it#10235: Interactive legend in dashboard and geostory
407112b 
Description:
- handle showing interactive legend option for dashboard and geostory
- handle saving layerFilter for dashboard and geostory
- add unit test
- add refactoring to StyleBasedWMSJsonLegend
@mahmoudadel54 mahmoudadel54 added this to the 2024.02.00 milestone Jun 14, 2024
@mahmoudadel54 mahmoudadel54 self-assigned this Jun 14, 2024
@mahmoudadel54 mahmoudadel54 linked an issue Jun 14, 2024 that may be closed by this pull request
Interactive legend in dashboard and geostory #10235
Closed
1 task
@allyoucanmap allyoucanmap merged commit 03ea83e into geosolutions-it:master Jun 17, 2024
@allyoucanmap
Copy link
Copy Markdown
Contributor

allyoucanmap commented Jun 17, 2024

@ElenaGallo please test this enhancement on dev, thanks

@ElenaGallo
Copy link
Copy Markdown
Contributor

ElenaGallo commented Jun 18, 2024 •
edited
Loading

Hi @mahmoudadel54 see my note below:

1_ On a geostory, if the interactive legend is enabled and set on a new map, it is not possible to edit it correctly on the map inline panel.

1.mp4

@allyoucanmap allyoucanmap mentioned this pull request Jun 21, 2024
Closed
12 tasks
@mahmoudadel54 mahmoudadel54 mentioned this pull request Jun 21, 2024
Merged
12 tasks
@allyoucanmap allyoucanmap mentioned this pull request Jul 24, 2024
Closed
3 tasks
@allyoucanmap
Copy link
Copy Markdown
Contributor

allyoucanmap commented Jul 24, 2024

Hi @mahmoudadel54 see my note below:

1_ On a geostory, if the interactive legend is enabled and set on a new map, it is not possible to edit it correctly on the map inline panel.

1.mp4

@ElenaGallo @tdipisa @mahmoudadel54 I opened a specific issue for this problem because there are side problems related to the way we managed the map configurations in GeoStories #10489

@ElenaGallo
Copy link
Copy Markdown
Contributor

ElenaGallo commented Aug 16, 2024

@mahmoudadel54 now the gray error page opens when the Interactive legend is enabled from the Settings layer the in the inline map editor.

How to Reproduce

geostory.mp4

@mahmoudadel54 mahmoudadel54 mentioned this pull request Aug 21, 2024
Merged
12 tasks
@mahmoudadel54
Copy link
Copy Markdown
Contributor Author

mahmoudadel54 commented Aug 21, 2024

@mahmoudadel54 now the gray error page opens when the Interactive legend is enabled from the Settings layer the in the inline map editor.

How to Reproduce

geostory.mp4

Hi @ElenaGallo
Actually this issue is not related to this PR but it is a regression due to this PR: #10438
I have raised a PR for fixing this issue: #10516

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@allyoucanmap allyoucanmap allyoucanmap approved these changes

Assignees

@mahmoudadel54 mahmoudadel54

Labels

C040-COMUNE_GE-2023-CUSTOM-SUPPORT

Projects

None yet

Milestone

2024.02.00

Development

Successfully merging this pull request may close these issues.

Interactive legend in dashboard and geostory

3 participants

@mahmoudadel54 @allyoucanmap @ElenaGallo