[Backport 2024.01.xx] #10289: Cursor position is shifted incorrectly in Localized number field component (#10312)#10346
Merged
dsuren1 merged 1 commit intogeosolutions-it:2024.01.xxfrom May 21, 2024
Conversation
…lized number field component (geosolutions-it#10312) * geosolutions-it#10289: Cursor position is shifted incorrectly in Localized number field component Description: - fix the jumping cursor to unexpected positions for localized numeric input * geosolutions-it#10289: Cursor position is shifted incorrectly in Localized number field component Description: - replace logic in updateDidMount to onKeyUp - remove unused comments * geosolutions-it#10289: Cursor position is shifted incorrectly in Localized number field component Description: - remove unused method in IntlNumberFormControl * geosolutions-it#10136: Search for Map CRS coordinates Description: - resolve FE failure in unit test * geosolutions-it#10289: Cursor position is shifted incorrectly in Localized number field component [resolve review comments] Description: - fix issue of on focus effect in NumericInput * geosolutions-it#10289: Cursor position is shifted incorrectly in Localized number field component [resolve review comments] Description: - fix FE issue in onKeyDown in IntlNumberFormControl * geosolutions-it#10289: Cursor position is shifted incorrectly in Localized number field component [resolve review comments] Description: - revert unnecessary change * geosolutions-it#10289: Cursor position is shifted incorrectly in Localized number field component [resolve review comments] Description: - move the fixing logic of cursor position to componentDidUpdate instead of onKeyUp * geosolutions-it#10289: Cursor position is shifted incorrectly in Localized number field component [resolve review comments] Description: - add onKeyUp as a prop into IntlNumberFormControl for any expected future consuming from a parent comp * geosolutions-it#10289: Cursor position is shifted incorrectly in Localized number field component [resolve review comments] Description: - add unit test - resolve review comments
1 task
12 tasks
dsuren1
approved these changes
May 21, 2024
Contributor
|
@ElenaGallo Kindly test it in QA. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Backport 2024.01.xx] - #10289: Cursor position is shifted incorrectly in Localized number field component (#10312)