Fix #10233 Add support for HTML response for WFS layer#10234
Fix #10233 Add support for HTML response for WFS layer#10234tdipisa merged 2 commits intogeosolutions-it:masterfrom
Conversation
|
Not sure if related to these changes, but I noticed that sometimes the selector of the layer, when no-layer is selected in the toc, fails. screencast-bpconcjcammlapcogcnnelfmaeghhagj-2024.04.23-11_53_34.webmNoticed that at the end of the video the selector is empty |
offtherailz
left a comment
There was a problem hiding this comment.
LGTM, only a few suggestion for improvements in doc / code,
Generally speaking looks good, just let's check that the issue I reported is not related with this changes.
In case let's open a separate issue.
web/client/utils/mapinfo/wfs.js
Outdated
| getIdentifyFlow: (layer = {}, baseURL, defaultParams) => { | ||
| const { point, features, ...baseParams } = defaultParams || {}; | ||
| if (features) { | ||
| if (baseURL && baseURL !== 'client') { |
There was a problem hiding this comment.
Now that client has a particular reserved meaing, I'd extract it in a constant and proper document it, so it is clear what is the scope.
web/client/utils/mapinfo/wfs.js
Outdated
| const buildRequest = (layer, { map = {}, point, currentLocale, params, maxItems = 10 } = {}, infoFormat, viewer, featureInfo) => { | ||
| if (point?.intersectedFeatures) { | ||
| const { features = [] } = point?.intersectedFeatures?.find(({ id }) => id === layer.id) || {}; | ||
| const isHTMLOutput = infoFormat === 'text/html'; |
There was a problem hiding this comment.
I should use isRemote as a flag, to identify the supported formats for remote request.
Description
This PR includes the possibility to use HTML get feature info for WFS when available as output format
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#10233
What is the new behavior?
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information