Description

This issue collects a few findings I discovered while checking the tool here.

1. It seems all times I try to use the Intersection process, the tool returns the same error. This need to be investigated
   

Below the WPS output:

<?xml version="1.0" encoding="UTF-8"?>
<wps:ExecuteResponse xmlns:xs="http://www.w3.org/2001/XMLSchema" xmlns:ows="http://www.opengis.net/ows/1.1" xmlns:wps="http://www.opengis.net/wps/1.0.0" xmlns:xlink="http://www.w3.org/1999/xlink" xml:lang="en" service="WPS" serviceInstance="https://gs-stable.geosolutionsgroup.com/geoserver/ows?authkey=f7a11038-a04d-4519-b778-d0994232e9ae&amp;" version="1.0.0">
	<wps:Process wps:processVersion="1.0.0">
		<ows:Identifier>gs:IntersectionFeatureCollection</ows:Identifier>
		<ows:Title>Intersection of Feature Collections</ows:Title>
		<ows:Abstract>Spatial intersection of two feature collections, including combining attributes from both.</ows:Abstract>
	</wps:Process>
	<wps:Status creationTime="2023-08-29T13:49:41.590Z">
		<wps:ProcessFailed>
			<ows:ExceptionReport version="1.1.0">
				<ows:Exception exceptionCode="NoApplicableCode">
					<ows:ExceptionText>Failed to retrieve value for input first feature collection</ows:ExceptionText>
				</ows:Exception>
			</ows:ExceptionReport>
		</wps:ProcessFailed>
	</wps:Status>
</wps:ExecuteResponse>

Does it maybe depends on the dataset used fro this test? In this case an hardening is requested.

2. There is no need to have the validation icon clickable as a button
   

3. Let's use simply GeoProcessing and Select the process to use
   

4. One of the main goal of a tool should be to display the result clearly without letting the user to find it. It is not the case here, where the result of the geoprocessing tools is not visible at the end:

   • Both Buffer and intersection layers are appended in TOC and for this reason they are not visible
     

   • At the end of the process the map should zoom to the interested area covered by the geometry produced by the process. At the same time the layer should have a good default style to properly highlight it and make it more evident. Where is the intersection below? This test has been performed using this map.
     

   • When selecting the layer result of a process, the "zoom to" doesn't appear in TOC toolbar but it should be.

5. Tow consecutive runs of the same process (and also more making the problem incremental) generate an inconsistent behavior in TOC. This test has been performed using this map.
   

   • I think it is totally useless to create at each run a new group in TOC and it must be avoided
   • In addition the layer name should have some sense, but it is also true the user can change it in a second moment throug layer settings (so nothing to do for this now)

6. When switching from a geoprocess to another, all the form should be cleaned (see also fix #9367 review of geo processing tool #9351). At the moment the previous selection performed by the client remains and it is not coherent with the state of the form
   

7. A more coherent tool icon must be created
   

8. If you click on the tool icon with the catalog tool opened the tool's panel is not visible. Visibility rules and thees kind of interactions must be better managed
   

9. Typo to be fixed for the following notification message
   

10. As I indicated here in the original issue, the request was to implement an extendable WPS tool also for future evolutions while, talking with @offtherailz that reviewed the work, it seems the current implementation it's overdressed on the two currently supported processes. An abstraction level in the middle should be present so, we have to discuss about thatWhat kind of improvement you want to add? (check one with "x", remove the others)

• Minor changes to existing features
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Other... Please describe:

Other useful information