You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Now the Edit Properties tool (from home page) and the Save tools (From map/dashboard and stories) use 2 different implementations:
One is valid for internal Save tool of Map, Dashboard and stories and use the generic ResourceModal component, self contained
One is valid only for Map and FeaturedMap in the home page. They use specific epics and checks, and have also the map details dialog
We need to reuse the generic component also for the Map/FeaturedMaps. This means that:
Acceptance Criteria
The generic resource modal component also have detail card.
An option should allow/deny to see/hide it by user role.
The detail card should be optional, because dashboards, for the moment, must not have it.
Detail card should be visible in Map's Save or Save As tool. <-- this can be tested from UI.
What kind of improvement you want to add? (check one with "x", remove the others)
Minor changes to existing features
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Other... Please describe:
Note for Developer
The ResourceModal support auto save of linkedResources and attributes, so please keep the same self-contained approch applying your changes, adding a fragment and reusing the same implicit save system you find for other attributes, linked resources (thumbnail) and permissions. At the end, remove all the logic that is not used anymore.
After this task has been done, the pull request Responsive Design - Info Box #5396 can continue, so the entry point for the administrator for the detail card is the Save / Save as tool.
Many issues was related to the tool that is going to be replaced with an existing one. So after this issue is closed, you can (and also developer should check) see that the following issues has been solved.
Create a new map, with a thumbnail and detail card
Edit the map you created removing the thumbnail, then save again
Edit again the map and try to edit detail
Try to Save Expected Result
The map is saved again with changes to the detail card Current Result
Click on save button has no effect. You have to edit also title or description to make it work.
This should have been solved by fixing the problem in NODATA handling (#5760) plus this fix.
Steps to reproduce MAPS
Login as admin
Create new map
Save writing only the name
Go back to homepage
From homepage, set a thumbnail, some detials and the permission Testers can edit
Logout from admin and login as tester
Open edit properties from homepage Problem 1: Can't see the details (NO_DETAILS_AVAILABLE) and can't edit them Problem 2: If I set a new thumbnail, the prevous one is not deleted (DELETE 403 forbidden)
DASHBOARDS AND STORIES
Login as admin
Create new dashboard/story
Save writing only the name
Go back to homepage
From homepage, set a thumbnail Problem 1: The console gives the following error: GET .../thumbnail 404 (Not Found)
Login as admin
Create new dashboard/story
Save writing only the name
Go back to homepage
From homepage, set the permission Testers can edit
Logout from admin and login as tester
Open edit properties from homepage Problem 2: Tryng to set a thumbnail in console: GET .../thumbnail 404 Not Found
Description
Now the Edit Properties tool (from home page) and the Save tools (From map/dashboard and stories) use 2 different implementations:
We need to reuse the generic component also for the Map/FeaturedMaps. This means that:
Acceptance Criteria
What kind of improvement you want to add? (check one with "x", remove the others)
Note for Developer
The ResourceModal support auto save of linkedResources and attributes, so please keep the same self-contained approch applying your changes, adding a fragment and reusing the same implicit save system you find for other attributes, linked resources (thumbnail) and permissions. At the end, remove all the logic that is not used anymore.
After this task has been done, the pull request Responsive Design - Info Box #5396 can continue, so the entry point for the administrator for the detail card is the Save / Save as tool.
The origina 'epic' for this task was Related resources saving flow issues due to permission updates - Reuse dashboard code #2908, but it's old, so some information can not be true anymore, I add it just as reference.
Notes for testers
Many issues was related to the tool that is going to be replaced with an existing one. So after this issue is closed, you can (and also developer should check) see that the following issues has been solved.
Now I'm closing them in favour of this one.
#3096 _Steps to reproduce_
Create a new map, with a thumbnail and detail card
Edit the map you created removing the thumbnail, then save again
Edit again the map and try to edit detail
Try to Save
Expected Result
The map is saved again with changes to the detail card
Current Result
Click on save button has no effect. You have to edit also title or description to make it work.
#3406
This should have been solved by fixing the problem in NODATA handling (#5760) plus this fix.
Steps to reproduce
MAPS
Login as admin
Create new map
Save writing only the name
Go back to homepage
From homepage, set a thumbnail, some detials and the permission Testers can edit
Logout from admin and login as tester
Open edit properties from homepage
Problem 1: Can't see the details (NO_DETAILS_AVAILABLE) and can't edit them
Problem 2: If I set a new thumbnail, the prevous one is not deleted (DELETE 403 forbidden)
DASHBOARDS AND STORIES
Login as admin
Create new dashboard/story
Save writing only the name
Go back to homepage
From homepage, set a thumbnail
Problem 1: The console gives the following error: GET .../thumbnail 404 (Not Found)
Login as admin
Create new dashboard/story
Save writing only the name
Go back to homepage
From homepage, set the permission Testers can edit
Logout from admin and login as tester
Open edit properties from homepage
Problem 2: Tryng to set a thumbnail in console: GET .../thumbnail 404 Not Found
- #4440 Improvement: allow editing detail card from Map viewer.
#4443
Steps to reproduce
Expected Result
The details are visible in the window
Current Result
The details windows shows the error: No_details_available