fix 2934 removed singlePage option, change default value virtualScroll (#2935)

MV88 · web-flow · commit 83def52b688f · 2018-05-21T16:05:01.000+02:00
diff --git a/web/client/components/data/download/DownloadDialog.jsx b/web/client/components/data/download/DownloadDialog.jsx
@@ -47,7 +47,7 @@ class DownloadDialog extends React.Component {
             {name: "native", label: "Native"},
             {name: "EPSG:4326", label: "WGS84"}
         ],
-        virtualScroll: false
+        virtualScroll: true
     };
 
     componentDidMount() {
diff --git a/web/client/components/data/download/DownloadOptions.jsx b/web/client/components/data/download/DownloadOptions.jsx
@@ -42,7 +42,7 @@ module.exports = class extends React.Component {
         wfsFormats: [],
         formats: [],
         srsList: [],
-        virtualScroll: false
+        virtualScroll: true
     };
 
     getSelectedFormat = () => {
@@ -82,6 +82,8 @@ module.exports = class extends React.Component {
                 value={this.getSelectedSRS()}
                 onChange={(sel) => this.props.onChange("selectedSrs", sel.value)}
                 options={this.props.srsList.map(f => ({value: f.name, label: f.label || f.name}))} />
+
+            {/* TODO for the future remove the virtualScroll prop since is no longer used*/}
             {this.props.virtualScroll ? null : <Checkbox checked={this.props.downloadOptions.singlePage} onChange={() => this.props.onChange("singlePage", !this.props.downloadOptions.singlePage ) }>
                 <Message msgId="wfsdownload.downloadonlycurrentpage" />
             </Checkbox>}
diff --git a/web/client/components/data/download/__tests__/DownloadOptions-test.jsx b/web/client/components/data/download/__tests__/DownloadOptions-test.jsx
@@ -43,16 +43,22 @@ describe('Test for DownloadOptions component', () => {
             onChange: () => {}
         };
         spyOn(events, "onChange");
-        ReactDOM.render(<DownloadOptions onChange={events.onChange} downloadOptions={{selectedFormat: "test"}} formats={[{name: "test"}]}/>, document.getElementById("container"));
+        ReactDOM.render(<DownloadOptions onChange={events.onChange} virtualScroll={false} downloadOptions={{selectedFormat: "test"}} formats={[{name: "test"}]}/>, document.getElementById("container"));
         const check = document.querySelector('input[type=checkbox]');
         check.click();
         expect(events.onChange).toHaveBeenCalled();
 
     });
-    it('singlePage checkbox not to render in virtualScroll mode', () => {
-        ReactDOM.render(<DownloadOptions virtualScroll downloadOptions={{selectedFormat: "test"}} formats={[{name: "test"}]}/>, document.getElementById("container"));
+    it('singlePage checkbox not to render: virtualScroll=true', () => {
+        ReactDOM.render(<DownloadOptions downloadOptions={{selectedFormat: "test"}} formats={[{name: "test"}]}/>, document.getElementById("container"));
         const check = document.querySelector('input[type=checkbox]');
         expect(check).toNotExist();
 
     });
+    it('singlePage checkbox to render: virtualScroll=false', () => {
+        ReactDOM.render(<DownloadOptions virtualScroll={false} downloadOptions={{selectedFormat: "test"}} formats={[{name: "test"}]}/>, document.getElementById("container"));
+        const check = document.querySelector('input[type=checkbox]');
+        expect(check).toExist();
+
+    });
 });
