The Hypercube space for binary vectors and labeled unweighted graphs #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is_bearable for type-checking to work with Python 3.8 and Python 3.9
stoprightthere
requested changes
Aug 12, 2024
Collaborator
stoprightthere
left a comment
There was a problem hiding this comment.
Nice job! I have left some comments about the code.
| The GeometricKernels space representing the d-dimensional hypercube graph | ||
| $C^d = \{0, 1\}^d$, the combinatorial space of binary vectors of length $d$. | ||
| The elements of this space are represented by d-dimensional boolean vectors. |
Collaborator
There was a problem hiding this comment.
is there a particular reason for using boolean vectors, as opposed to, say, integer vectors?
Member
Author
There was a problem hiding this comment.
- To save memory. In the implementation of my dreams, they should be actual bit-arrays. This is much harder than what I did here though, especially if the implementation should be backend-independent.
- Interpretation. This is a space of binary vectors. Binary ≈ Boolean.
Collaborator
There was a problem hiding this comment.
Bool requires as much memory as int, so this argument doesn't quite hold. And everyone knows that binary means zeros and ones :)
…lper.py. For imports to work, add __init__.py throughout the tests/ folder hierarchy
Member
Author
|
Revised. |
…ls/GeometricKernels into slava/binary_graph_space
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a new space: the hypercube graph space$\{0,1\}^d$ of binary vectors.
It includes a new space (
HypercubeGraph), the respective notebookHypercubeGraph.ipynb, a theory pagedocs/theory/hypercube_graph.rst, and tests.