Merged
Conversation
Without this fix, propshaft would generate new digest filenames every time you change a JS file in development, which would cause the browser to 404 when requesting the new file when you reloaded. This would only be resolved by restarting the rails server. Now, if you change a JS file in local dev and reload, the browser importmap will pick up the new path to the file.
|
Demo app download link: https://github.com/geoblacklight/geoblacklight/actions/runs/19349034476/artifacts/4562743988
|
jcoyne
approved these changes
Nov 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this fix, propshaft would generate new digest filenames
every time you change a JS file in development, which would
cause the browser to 404 when requesting the new file when
you reloaded. This would only be resolved by restarting the
rails server.
Now, if you change a JS file in local dev and reload, the browser
importmap will pick up the new path to the file.