Fix installation order in template.rb builds#1689
Merged
Conversation
Both asset pipelines use it, so this just installs it before invoking either pipeline.
164b90c to
ed6ebd4
Compare
|
Demo app download link: https://github.com/geoblacklight/geoblacklight/actions/runs/19315238942/artifacts/4549946464
|
dl-maura
approved these changes
Nov 13, 2025
Contributor
dl-maura
left a comment
There was a problem hiding this comment.
worked with @thatbudakguy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes two changes that are necessary for
template.rbbuilds to succeed:after_bundleblock like Blacklight does, so that asset files have already been created when we try to modify them@geoblacklight/frontendpackage is installed regardless of our choice of asset generator, since both use it (for importmaps we weren't installing it)