Index test fixtures using the gem path#1688
Merged
Conversation
e493ac6 to
60e196e
Compare
|
Demo app download link: https://github.com/geoblacklight/geoblacklight/actions/runs/19313081720/artifacts/4549160603
|
60e196e to
b263d66
Compare
This lets us pull in the fixture data from Geoblacklight's repo without needing to fetch it remotely from GitHub, by referencing the files that are bundled with the gem. These always get installed in your local Geoblacklight, so they're already there for you to use. Works both when working on the Geoblacklight gem and working on your local install. Might fix #1668.
In testing template.rb builds, I was seeing that newly created apps would fail at the indexing test fixtures step with ECONNRESET. Adding a slight delay for solr to finish loading the core config solved it.
712dda9 to
4216645
Compare
dl-maura
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This lets us pull in the fixture data from Geoblacklight's repo
without needing to fetch it remotely from GitHub, by referencing
the files that are bundled with the gem. These always get
installed in your local Geoblacklight, so they're already there
for you to use.
Works both when working on the Geoblacklight gem and working on
your local install.
Might fix #1668.
Makes #1676 unnecessary because we don't need to do remote
indexing of fixtures anymore.
Also adds a slight delay after solr is loaded in docker to fix issues
where indexing was rejected because the core wasn't ready.