Skip to content

Ensure the right JS pipeline is selected for Rake tasks#1640

Merged
thatbudakguy merged 1 commit intomainfrom
rakefile-js-options
Jan 22, 2025
Merged

Ensure the right JS pipeline is selected for Rake tasks#1640
thatbudakguy merged 1 commit intomainfrom
rakefile-js-options

Conversation

@thatbudakguy
Copy link
Member

@thatbudakguy thatbudakguy commented Jan 22, 2025

Fixes #1639

@github-actions
Copy link

github-actions bot commented Jan 22, 2025 •
edited
Loading

Demo app download link: https://github.com/geoblacklight/geoblacklight/actions/runs/12917657703/artifacts/2471025155

  1. Download demo app and unzip file
  2. Change into app directory
    • run docker compose pull
    • run docker compose up
  3. Open in browser

@dnoneill
Copy link
Contributor

dnoneill commented Jan 22, 2025 •
edited
Loading

@thatbudakguy It is running but the app is giving the error

Vite Ruby can't find entrypoints/application.scss in the manifests.

Possible causes:
  - The last build failed. Try running `bin/vite build --clear --mode=development` manually and check for errors.

Errors:
  x Build failed in 82ms
  error during build:
  [vite:css] Preprocessor dependency "sass-embedded" not found. Did you install it? Try `yarn add -D sass-embedded`.
  file: /Users/noneill/projects/geoblacklight/.internal_test_app/app/javascript/entrypoints/application.scss
      at loadPreprocessorPath (file:///Users/noneill/projects/geoblacklight/.internal_test_app/node_modules/vite/dist/node/chunks/dep-CHZK6zbr.js:37292:13)
      at loadSassPackage (file:///Users/noneill/projects/geoblacklight/.internal_test_app/node_modules/vite/dist/node/chunks/dep-CHZK6zbr.js:37307:19)
      at process (file:///Users/noneill/projects/geoblacklight/.internal_test_app/node_modules/vite/dist/node/chunks/dep-CHZK6zbr.js:37553:27)
      at compileCSSPreprocessors (file:///Users/noneill/projects/geoblacklight/.internal_test_app/node_modules/vite/dist/node/chunks/dep-CHZK6zbr.js:36742:34)
      at compileCSS (file:///Users/noneill/projects/geoblacklight/.internal_test_app/node_modules/vite/dist/node/chunks/dep-CHZK6zbr.js:36796:38)
      at async Object.transform (file:///Users/noneill/projects/geoblacklight/.internal_test_app/node_modules/vite/dist/node/chunks/dep-CHZK6zbr.js:36171:11)
      at async transform (file:///Users/noneill/projects/geoblacklight/.internal_test_app/node_modules/rollup/dist/es/shared/node-entry.js:19794:16)
      at async ModuleLoader.addModuleSource (file:///Users/noneill/projects/geoblacklight/.internal_test_app/node_modules/rollup/dist/es/shared/node-entry.js:20007:36)
  error Command failed with exit code 1.

running yarn add -D sass-embedded in internal test app fixes it.

@thatbudakguy
Copy link
Member Author

thatbudakguy commented Jan 22, 2025

I forgot another option :/ try again now? I think we needed --css bootstrap too

@dnoneill
Copy link
Contributor

dnoneill commented Jan 22, 2025

@thatbudakguy

NoMethodError: undefined method `new' for module EngineCart::RakeTask (NoMethodError)

EngineCart::RakeTask.new

dnoneill
dnoneill requested changes Jan 22, 2025
View reviewed changes
@thatbudakguy thatbudakguy merged commit 27ec50b into main Jan 22, 2025
14 checks passed
@thatbudakguy thatbudakguy deleted the rakefile-js-options branch January 22, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dnoneill dnoneill dnoneill approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

geoblacklight:server is not working

2 participants

@thatbudakguy @dnoneill