Skip to content

Remove solr_wrapper dependency and use docker#1612

Merged
ewlarson merged 2 commits intomainfrom
1611-solr-wrapper
Sep 27, 2024
Merged

Remove solr_wrapper dependency and use docker#1612
ewlarson merged 2 commits intomainfrom
1611-solr-wrapper

Conversation

@eliotjordan
Copy link
Member

Closes #1611

@github-actions
Copy link

github-actions bot commented Sep 20, 2024

Demo app download link: https://github.com/geoblacklight/geoblacklight/actions/runs/11054673741/artifacts/1982902255

  1. Download demo app and unzip file
  2. Change into app directory
    • run docker compose pull
    • run docker compose up
  3. Open in browser

@eliotjordan eliotjordan force-pushed the 1611-solr-wrapper branch 3 times, most recently from 956463d to fb054d1 Compare September 21, 2024 04:22
@eliotjordan eliotjordan changed the title Remove solr_wrapper dependecy and use docker Remove solr_wrapper dependency and use docker Sep 21, 2024
@eliotjordan eliotjordan marked this pull request as ready for review September 23, 2024 17:24
@thatbudakguy
Copy link
Member

I might be missing something, but does running bundle exec rake ci work for you? For me, the Docker stack is not started, and all the tests that need to connect to solr fail. There's no output in the terminal indicating that the system call to invoke compose happened.

If this is indeed a bug, I think it might be being masked in CI by the fact that the CI build already invokes compose, so it will have the containers running regardless:

- name: Run docker compose
run: docker compose up -d

@eliotjordan
Copy link
Member Author

@thatbudakguy Good catch. Updated the PR to start and stop solr as part of the ci task.

Copy link
Member

@thatbudakguy thatbudakguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

running tests went smoothly this time; everything looks good.

@ewlarson ewlarson merged commit 7227660 into main Sep 27, 2024
@ewlarson ewlarson deleted the 1611-solr-wrapper branch September 27, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace solr_wrapper with docker compose

3 participants