Configure the logo rather than overriding#1563
Merged
eliotjordan merged 1 commit intomainfrom Aug 23, 2024
Merged
Conversation
|
Demo app download link: https://github.com/geoblacklight/geoblacklight/actions/runs/10531276655/artifacts/1848614946
|
e58fc1c to
9197696
Compare
c09dfc6 to
0d29dca
Compare
eliotjordan
requested changes
Aug 23, 2024
Member
eliotjordan
left a comment
There was a problem hiding this comment.
Though it seems like this should work, the generated app has a blank logo.
Collaborator
Author
|
Collaborator
Author
|
This has got to be broken on the main branch too, right? Because image_url is a sprockets thing and we're using propshaft? |
Collaborator
Author
|
Nope, in main: |
002cd46 to
26d3979
Compare
Collaborator
Author
|
@eliotjordan I had to update the vite config for the so that It can deal with the |
eliotjordan
approved these changes
Aug 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it easier for downstream apps to configure their own logos and results in less overall css.