Skip to content

don't display login link component if logged in#1470

Merged
ewlarson merged 1 commit intomainfrom
login-fix
Aug 8, 2024
Merged

don't display login link component if logged in#1470
ewlarson merged 1 commit intomainfrom
login-fix

Conversation

@dnoneill
Copy link
Contributor

@dnoneill dnoneill commented Aug 8, 2024

Before

Screenshot 2024-08-08 at 2 35 19 PM

After

Screenshot 2024-08-08 at 2 40 09 PM

closes #1469

@github-actions
Copy link

github-actions bot commented Aug 8, 2024

Demo app download link: https://github.com/geoblacklight/geoblacklight/actions/runs/10307984219/artifacts/1792003033

  1. Download demo app and unzip file
  2. Change into app directory
    • run docker compose pull
    • run docker compose up
  3. Open in browser

@ewlarson ewlarson self-assigned this Aug 8, 2024
@ewlarson ewlarson self-requested a review August 8, 2024 18:58
Copy link
Member

@ewlarson ewlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 // Just added some screenshots to the PR here to better illustrate the issue.

@ewlarson ewlarson merged commit 4a98fbb into main Aug 8, 2024
@ewlarson ewlarson deleted the login-fix branch August 8, 2024 19:43
@dnoneill
Copy link
Contributor Author

dnoneill commented Aug 8, 2024

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

fix login button

2 participants