Add docker compose option for solr only and modify Rakefile#1450
Merged
eliotjordan merged 2 commits intomainfrom Aug 1, 2024
Merged
Add docker compose option for solr only and modify Rakefile#1450eliotjordan merged 2 commits intomainfrom
eliotjordan merged 2 commits intomainfrom
Conversation
1c43b0d to
7929d73
Compare
eliotjordan
requested changes
Jul 31, 2024
Member
eliotjordan
left a comment
There was a problem hiding this comment.
This is great! Seems compatible with the build and docker PR I posted earlier. Only thing is to change is the name of the compose file.
87589de to
3195e53
Compare
3195e53 to
7955eb2
Compare
eliotjordan
approved these changes
Aug 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Downloading and building Solr and the rebuilding of internal test app so many times was a pain point for our dev team. This PR is meant to make development easier and is not related to production builds. It removes a redundant
engine_cart:generatestatement, adds an option to run Solr in docker, and makes it easier overall to run Solr and the application separately. I followed the pattern we used in Arclight development, another downstream-from-Blacklight rails engine, which has worked pretty well for us.If approved, I have drafted updated documentation that I will PR in that repo.