PB-170: Add device orientation to geolocation button - #minor#965
PB-170: Add device orientation to geolocation button - #minor#965
Conversation
Passing run #2995 ↗︎
Details:
Review all test suite changes for PR #965 ↗︎ |
|||||||||||||||
a72d79c to
0ed8c6b
Compare
412469e to
78d0ccf
Compare
the vision cone is otherwise too small on Retina devices (iPhone and such)
78d0ccf to
c39a9e4
Compare
c39a9e4 to
3314576
Compare
ltshb
left a comment
There was a problem hiding this comment.
What is this PR ? What should I review ? Could you please update the PR title to provide information on what is asked to review here
ltshb
left a comment
There was a problem hiding this comment.
I don't fully get the auto rotation and based on the PR description it seems that it don't work, at least on my mobile phone touching geolocation again would disable the geolocation and not re-orient to the north if not in the north.
Does your device have absolute orientation (magnetic sensors)? If not this is expected behavior with the current code as pressing the geolocation button again should just turn off the geolocation if the phone does not have absolute orientation |
e98c8fc to
cf87b62
Compare
3831d08 to
5be76ac
Compare
|
is replaced by #1022 |
Add vision cone to geolocation if information is available through geolocation api or magnetometer to indicate the users orientation.
If a magnetometer is available, clicking the geolocation a second time will rotate the map to align it to north
Test link