PB-570 : use service-proxy for failed KML/GPX URL import#900
Merged
Conversation
Passing run #2486 ↗︎
Details:
Review all test suite changes for PR #900 ↗︎ |
|||||||||||||||
049a2a4 to
a102b02
Compare
a102b02 to
d7e38fe
Compare
ltshb
approved these changes
Jun 11, 2024
Contributor
|
@pakb Don't forget to change the staging before merge |
this should enable Dropbox/Google Drive/name your cloud provider users, for which the provider has explicitly not implemented CORS header, to still be able to import their file on our viewer. This is a temporary solution to ease the go-live, but we need to think long-term how we want to deal with that (or if we want to stop supporting it)
d7e38fe to
7b8744a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this should enable Dropbox/Google Drive/name your cloud provider users, for which the provider has explicitly not implemented CORS header, to still be able to import their file on our viewer.
This is a temporary solution to ease the go-live, but we need to think long-term how we want to deal with that (or if we want to stop supporting it)
Send me a PM on Slack to get a valid URL to my dropbox, I've uploaded a sample KML there
Test link