PB-621: Fixed default lang with -CH suffix#897
Merged
Conversation
pakb
reviewed
Jun 11, 2024
043260a to
7fea04b
Compare
Passing run #2484 ↗︎
Details:
Review all test suite changes for PR #897 ↗︎ |
|||||||||||||||
pakb
approved these changes
Jun 11, 2024
Contributor
pakb
left a comment
There was a problem hiding this comment.
I've never experienced the case/bug on my device so I can't really test if it fixes it, but from code point of view, looking good
The `-CH` local suffix is not supported by our API backend. The default language was set to the default browser language which could be de-CH or fr-CH.
7fea04b to
88aa2b9
Compare
Contributor
Author
@pakb To reproduce the error you need to set the default/preferred language of chrome to de-CH or fr-CH 😉 then start the application without parameters. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
-CHlocal suffix is not supported by our API backend. The defaultlanguage was set to the default browser language which could be de-CH or fr-CH.
Test link