Merged
Conversation
Passing run #2490 ↗︎
Details:
Review all test suite changes for PR #895 ↗︎ |
|||||||||||||||
24b70c3 to
8512534
Compare
pakb
reviewed
Jun 11, 2024
Contributor
pakb
left a comment
There was a problem hiding this comment.
There's a little improvement that could still be made, when drawing something that shows a profile the title "Edit object" appears in the profile infobox, even though the "edit" part is on the map
pakb
approved these changes
Jun 11, 2024
The infobox only had the profile title but not on object or in drawing.
Also made the title truncated if it don't have enough space.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The infobox only had the profile title but not on object or in drawing.
Test link