Fix tooltip movable window pointer and icon issues#894
Merged
Conversation
Passing run #2468 ↗︎
Details:
Review all test suite changes for PR #894 ↗︎ |
|||||||||||||||
7713bdd to
6ce9565
Compare
pakb
approved these changes
Jun 11, 2024
| * app (such as the header) to be accessible to the movable element | ||
| * | ||
| * @param element | ||
| * @param element Reference to an DOM element |
Contributor
There was a problem hiding this comment.
small typo here Reference to a DOM element (DOM might have been added later 😉 )
6ce9565 to
a8c1bb4
Compare
The pointer was not set to `move` on the movable window header. Also clicking on the window header buttons (close, print, ...) triggered also a move event which is unwanted. Made also the use movable composable usable if the component is not mounted and fixed default params.
a8c1bb4 to
884f9bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pointer was not set to
moveon the movable window header. Also clickingon the window header buttons (close, print, ...) triggered also a move event
which is unwanted.
Made also the use movable composable usable if the component is not mounted
and fixed default params.
Test link