PB-449: Add a minimize button to give feedback and report problem#893
Merged
PB-449: Add a minimize button to give feedback and report problem#893
Conversation
Passing run #2474 ↗︎
Details:
Review all test suite changes for PR #893 ↗︎ |
|||||||||||||||
4380d73 to
2605f85
Compare
pakb
approved these changes
Jun 11, 2024
Contributor
pakb
left a comment
There was a problem hiding this comment.
not something you should fix in the scope of this PR, but if you open both "modals" they stack over one another (feedback + report), might be better to close the other one
Contributor
Author
Yes but this is only an issue on dev staging on prod and test map we don't have both button only one or the other 😉 |
The first idea was to use movable but this cause trouble with the content of the window not being at a fix size like for the tooltip but dependent on the window content. As simpler alternative I added the minimize button which let the user minimize the window which is for the use case good enough.
2605f85 to
6883a2f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first idea was to use movable but this cause trouble with the content of
the window not being at a fix size like for the tooltip but dependent on the
window content.
As simpler alternative I added the minimize button which let the user minimize
the window which is for the use case good enough.
Test link