PB-607: Fix drawing share URL: use full query params in share url#892
Merged
PB-607: Fix drawing share URL: use full query params in share url#892
Conversation
Passing run #2444 ↗︎
Details:
Review all test suite changes for PR #892 ↗︎ |
|||||||||||||||
When sharing a drawing, only the KML layer was added to the query params. On the old viewer the full url param were added to the share url which provide then the same view as the view the drawer used (e.g zoom level, center, layer stacking, background, ...)
4bc2edc to
8750d31
Compare
schtibe
approved these changes
Jun 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When sharing a drawing, only the KML layer was added to the query params.
On the old viewer the full url param were added to the share url which provide
then the same view as the view the drawer used (e.g zoom level, center, layer
stacking, background, ...)
Test link