Conversation
Passing run #2408 ↗︎
Details:
Review all test suite changes for PR #885 ↗︎ |
|||||||||||||||
ltshb
approved these changes
Jun 10, 2024
using stock Cesium classes to load KMLs instead of relying on ol-cesium bridge transforming the Cesium KML component into a composition API component in the process (exit mixins) Adding a couple tweaks depending on the geometry type : - disabling depth with terrain testing with labels (always visible) and adding more outline - clamping icons (billboard) to the terrain, so that they aren't clipped by it - lowering the default alpah/transparency of polyline/polygon material, to ease the visualization of underlying buildings and other features - forcing clamping to ground for polyline, meaning a measure line will follow the terrain, always
cd18c05 to
8f2138b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
using stock Cesium classes to load KMLs instead of relying on ol-cesium bridge transforming the Cesium KML component into a composition API component in the process (exit mixins)
Adding a couple tweaks depending on the geometry type :
Note : see JIRA ticket for good KML sample to be tested
Test link