PB-548 : fix camera position present in URL at startup issue#881
Merged
PB-548 : fix camera position present in URL at startup issue#881
Conversation
Passing run #2410 ↗︎
Details:
Review all test suite changes for PR #881 ↗︎ |
|||||||||||||||
79401cc to
a6efde5
Compare
a6efde5 to
9c425bd
Compare
ltshb
approved these changes
Jun 10, 2024
Comment on lines
+50
to
+55
| store.subscribeAction({ | ||
| after: (action, state) => { | ||
| if (state.position.camera === null) { |
Contributor
There was a problem hiding this comment.
Maybe put a comment here why we use action subscription instead of mutation as we usually do mutation watcher
Removing 2D position URL params when 3D is active to diminish issues when we load the app directly in 3D. When zoom and/or position are present, the 3D viewer would react to changes in these values. This was creating some race condition issue at startup when a camera position was also described in the URL. Camera initialization has also been separated from the logic to move the camera after init, so that we have a clearer logical decision (with logging)
9c425bd to
f4cd7e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing 2D position URL params when 3D is active to diminish issues when we load the app directly in 3D. When zoom and/or position are present, the 3D viewer would react to changes in these values. This was creating some race condition issue at startup when a camera position was also described in the URL.
Camera initialization has also been separated from the logic to move the camera after init, so that we have a clearer logical decision (with logging)
Test link