PB-574: Fix layers parameter issue at startup#879
Merged
Conversation
Passing run #2392 ↗︎
Details:
Review all test suite changes for PR #879 ↗︎ |
|||||||||||||||
External layers (kml, gpx, wmts, wms) at the bottom of the stack where replaced by default topic layers during startup if the layers came from a legacy link. This issue was due to a performance improvement that avoid to recreated layer object if it was already present, but this performance improvement did not check if the layer at index was the correct ID.
Each layer might have a default opacity from the layer config therefore only clone current layer config for external layers and kml (kml created by the web-mapviewer are not considered as external).
73b3680 to
f2ea5bb
Compare
pakb
approved these changes
Jun 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
External layers (kml, gpx, wmts, wms) at the bottom of the stack where replaced
by default topic layers during startup if the layers came from a legacy link.
This issue was due to a performance improvement that avoid to recreated layer
object if it was already present, but this performance improvement did not check
if the layer at index was the correct ID.
Test link