PB-521: fix geolocation tracking, zindex and accuracy and several geolocation improvements#864
Merged
PB-521: fix geolocation tracking, zindex and accuracy and several geolocation improvements#864
Conversation
Passing run #2322 ↗︎
Details:
Review all test suite changes for PR #864 ↗︎ |
|||||||||||||||
f305a37 to
202a77b
Compare
Contributor
Author
|
@pakb this solve PB-521 but still require to implement the geolocation marker on 3D. I'm also wondering if we should not add the |
pakb
reviewed
May 27, 2024
src/modules/map/components/openlayers/OpenLayersAccuracyCircle.vue
Outdated
Show resolved
Hide resolved
Contributor
|
As I'm guessing you're already in vacation, I'll take over the little changes I proposed 😉 |
The geolocation circle was not always on top of the map, if you added a new map then it covered the geolocation circle. Also simlified the z-index computation, always reserve the z-index for the elements even if they are not enabled, this make a code simpler and more robust.
Vue requires a template
The geolocation API might return a double number for the accuracy, in this case the accuracy was ignored. Now it is correctly set and if it is not a valid number an error is printed.
The geolocation tracking on non touch device was canceled as soon as the mouse moved on the map, even if not action was undertaken ! Now we use the setCenter to cancel the tracking, unless the setCenter is triggered by the geolocation. Also did some improvement using the geolocation API by allowing cached location and setting a timeout. Also when re-activating the geolocation we first set the previous location to make the app more reactive.
no empty divs in template use of our already implemented utils to detect if geolocation accuracy is a number
202a77b to
b36092a
Compare
pakb
approved these changes
May 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The geolocation tracking on non touch device was canceled as soon as the mouse
moved on the map, even if not action was undertaken ! Now we use the setCenter
to cancel the tracking, unless the setCenter is triggered by the geolocation.
Also did some improvement using the geolocation API by allowing cached location
and setting a timeout.
Also when re-activating the geolocation we first set the previous location
to make the app more reactive.
Also fixed the geolocation z-index, the geolocaiton marker would have been put behind new layers.
Test link