PB-505: Added error when external WMTS layer don't support WGS84#860
Merged
PB-505: Added error when external WMTS layer don't support WGS84#860
Conversation
62acb1f to
c3c6a18
Compare
pakb
reviewed
May 23, 2024
| * @param {string} layerId ID of the layer(s) to retrieve | ||
| * @returns {[AbstractLayer]} All active layers matching the ID | ||
| */ | ||
| getLayersById: (state) => (layerId) => { |
Contributor
There was a problem hiding this comment.
might be good to rename that to getActiveLayerById, as it stands it could make you think it will lookup the whole layers config, but in reality will only seek matches in the active layers (preview layer is kind of an active layer too...)
Contributor
Author
There was a problem hiding this comment.
@pakb that is not a good idea, the catalogue uses getActiveLayersById to add/remove layer from the active layer list, here we definitely don't want to have the previewLayer
Passing run #2301 ↗︎
Details:
Review all test suite changes for PR #860 ↗︎ |
|||||||||||||||
c3c6a18 to
aa5207a
Compare
For this I needed to be able to add/remove errors per layer as this error is only for 3D.
aa5207a to
824aab0
Compare
pakb
approved these changes
May 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For this I needed to be able to add/remove errors per layer as this error is
only for 3D.
Test link